Typing, linter fixes, splitting up code into files #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes from the MixIn pattern to direct inheritance (since it only inherits from one class) and adds type hints to pretty much every arg and return. Since the MixIn was not combining many classes, this should work just as well and it's better supported by the 'magic' of modern IDEs.
It passes the limited pytest implementation, but I'm not so familiar with this module and it's quite likely that this could break things. So I'd advise against merging it without doing at least some basic tests yourself.
It also allows use with python 3.13.