Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

410: Fixed issue where null coalescing operator combined with "||" or "&&" resulted in syntax errors. #417

Merged
merged 2 commits into from
Feb 22, 2025

Conversation

ErikvO
Copy link

@ErikvO ErikvO commented Feb 21, 2025

Fixes #410 by changing the OperatorPrecedence of NullCoalesce to be higher than LogicalOr and LogicalAnd.
Added unit tests for these cases.

@trullock
Copy link
Owner

thanks

having trouble with my machine at the moment, bump the minor revision in the project and update the changelog and push that commit and i'll merge it, AppVeyor will publish it automatically

@ErikvO
Copy link
Author

ErikvO commented Feb 21, 2025

Done
I was not completely sure which part of the version you would like to have bumped. You mentioned:

minor revision

but as I understand it, versions consist of major.minor.revision

Seeing the previous changes only updated the revision part, I opted to do the same.
If this is not correct, I would be happy to amend the commit.

@trullock trullock merged commit 0a64dff into trullock:master Feb 22, 2025
1 check passed
@ErikvO ErikvO deleted the bug_410 branch February 24, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Null coalescing operator combined with "||" or "&&"
2 participants