Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NavSatFix publisher for GNSS simulation #340

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

Autumn60
Copy link
Contributor

  • add geographic coordinate calculation scripts (GeoCoordinate.cs, GeoCoordinateConverter.cs)
  • add parameter that can be set from the Inspector window for geographic calculation to Environment.cs
  • add GnssRos2NavSatFixPublisher.cs to publish sensor_msgs/NavSatFix topic
    To minimize impact on other projects, it's implemented separately from the existing GnssRos2Publisher.

The motivation is to test eagleye at runtime with AWSIM.

ref link:
Geographpic coordinate calculations are implemented with reference to the following sites
=> https://vldb.gsi.go.jp/sokuchi/surveycalc/main.html

@Autumn60 Autumn60 requested a review from mackierx111 July 31, 2024 05:59
@Autumn60 Autumn60 changed the title feature: NavSatFix publisher for GNSS simulation feat: NavSatFix publisher for GNSS simulation Jul 31, 2024
Copy link
Collaborator

@mackierx111 mackierx111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good implementation! Please check out the comments.

@Autumn60 Autumn60 requested a review from mackierx111 August 1, 2024 08:08
@Autumn60
Copy link
Contributor Author

Autumn60 commented Aug 1, 2024

@mackierx111
Thank you for your accurate point.
I've corrected the relevant section.

Copy link
Collaborator

@mackierx111 mackierx111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@mackierx111 mackierx111 merged commit 851cf2f into main Aug 1, 2024
1 of 2 checks passed
@Autumn60 Autumn60 deleted the feature/nav_sat_fix_publishment branch August 1, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants