Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate energy loss feature to lidar snow #283

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Integrate energy loss feature to lidar snow #283

merged 3 commits into from
Apr 22, 2024

Conversation

msz-rai
Copy link
Contributor

@msz-rai msz-rai commented Mar 19, 2024 •
edited by prybicki
Loading

This PR provides interface extension to the snow simulation feature. It adds the following widgets:

  • checkbox DoSimulateEnergyLoss - switches between snow simulation methods - if false, the algorithm takes into account only the closest snowflake in the ray beam. If true, it takes into account all snowflakes in the ray beam and computes energy loss.
  • slider SnowflakeOccupancyThreshold - Allows to ignore snowflakes that are less than given fraction of ray beam, as if they were transparent.

@PawelLiberadzki PawelLiberadzki marked this pull request as ready for review March 27, 2024 17:19
@mackierx111 mackierx111 self-requested a review April 18, 2024 12:04
mackierx111
mackierx111 approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@mackierx111 mackierx111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mackierx111 mackierx111 merged commit 15231f9 into main Apr 22, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mackierx111 mackierx111 mackierx111 approved these changes

@PawelLiberadzki PawelLiberadzki PawelLiberadzki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@msz-rai @mackierx111 @PawelLiberadzki @prybicki