Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(random_traffic): fix spawn issue - distance_to_stop #127

Merged
merged 2 commits into from
May 14, 2023

Conversation

dmoszynski
Copy link
Contributor

If the vehicle spawns close to the already existing vehicle, and this distance is smaller than MinFrontVehicleDistance, then the distanceToStopPointByFrontVehicle is in infinite, and spawned vehicle ignores everything in front of him.
This commit fixes this problem - the distance to the front of vehicles is calculated correctly.
I also corrected some typos.

Main

before.mp4

Fixed

after.mp4

@dmoszynski dmoszynski added the bug Something isn't working label May 12, 2023
@dmoszynski dmoszynski requested a review from mackierx111 May 12, 2023 10:33
Copy link
Collaborator

@mackierx111 mackierx111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the implementation, LGTM!

@mackierx111 mackierx111 merged commit 75d11b5 into main May 14, 2023
@mackierx111 mackierx111 deleted the fix/random_traffic_distance_to_stop branch May 14, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants