Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Adjust mesh2pcd to RGL v13 #116

Merged
merged 5 commits into from
Apr 24, 2023
Merged

Conversation

msz-rai
Copy link
Contributor

@msz-rai msz-rai commented Apr 19, 2023

This PR fixes mesh2pcd feature to run with RGL v0.13.0.
It also updates the RGL version to v0.13.1.

Known issue:

  • Saving huge point clouds (> 350 000 000 points) on Windows crashes AWSIM.

@msz-rai msz-rai requested review from mackierx111 and prybicki April 19, 2023 11:29
Copy link
Collaborator

@mackierx111 mackierx111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msz-rai
Thanks for the implementation!
Have you checked that the mesh2pcd function works properly in windows, ubuntu?

I would like to leave the code checking to @prybicki

@msz-rai
Copy link
Contributor Author

msz-rai commented Apr 19, 2023

@mackierx111

Have you checked that the mesh2pcd function works properly in windows, ubuntu?

Yes, I have checked it. It works well on Windows and Ubuntu (except for saving large point clouds on Windows, as mentioned in the description).

@prybicki
Copy link
Contributor

@mackierx111 Surely, I will review it by the end of the week.

@mackierx111 mackierx111 merged commit 78af12b into main Apr 24, 2023
@mackierx111 mackierx111 deleted the fix/adjust-mesh2pcd-to-rgl-v13 branch April 24, 2023 08:30
tyongingo pushed a commit to tyongingo/AWSIM that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants