Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add V2I feature #109

Merged
merged 12 commits into from
May 12, 2023
Merged

Add V2I feature #109

merged 12 commits into from
May 12, 2023

Conversation

lchojnack
Copy link
Contributor

@lchojnack lchojnack commented Apr 7, 2023 •
edited
Loading

Feature description:

  • V2I prefab includes the following:
    • configuration of ‘distance is just less than X meter from Ego’
    • configuration of topic frequency
    • configuration of ‘topic_name’, and qos setting
    • possibility of turning on/off the publication on topic

Screenshot_20230412_164542

  • Added the ‘Lanelet Element ID' to ‘Traffic Light’ game objects. When ‘Lanelet Element ID' is '0' (default value) then the traffic signal is not published.

Screenshot_20230412_164542

  • Fill ‘traffic_light_id’ from the lanelet map to Traffic Light game objects.

dmoszynski and others added 7 commits April 6, 2023 18:10
@lchojnack lchojnack marked this pull request as ready for review April 12, 2023 14:59
@lchojnack lchojnack requested a review from mackierx111 April 12, 2023 15:25
@lchojnack lchojnack marked this pull request as draft April 13, 2023 09:01
@lchojnack
Publish only turned on bulbs
67f5c6e 
Signed-off-by: Lukasz Chojnacki <[email protected]>
@lchojnack lchojnack marked this pull request as ready for review April 19, 2023 13:36
mackierx111
mackierx111 requested changes Apr 20, 2023
View reviewed changes
@mackierx111
Copy link
Collaborator

@lchojnack
Thanks for the implementation! I think it is a nice design. I made a few comments.

@lchojnack lchojnack requested a review from mackierx111 April 24, 2023 13:57
mackierx111
mackierx111 requested changes May 11, 2023
View reviewed changes
Copy link
Collaborator

@mackierx111 mackierx111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good implementation. I commented one.

@lchojnack
Change egoVehicleTransform parameter to public. Do not raise an error…
cb92392 
… when ego transform is not referenced

Signed-off-by: Lukasz Chojnacki <[email protected]>
@lchojnack lchojnack requested a review from mackierx111 May 11, 2023 16:06
mackierx111
mackierx111 approved these changes May 12, 2023
View reviewed changes
Copy link
Collaborator

@mackierx111 mackierx111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mackierx111 mackierx111 merged commit 9c83460 into main May 12, 2023
@mackierx111 mackierx111 deleted the feature/AJD-689_v2i_feature_traffic_signals branch May 12, 2023 04:27
@lchojnack lchojnack mentioned this pull request Aug 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mackierx111 mackierx111 mackierx111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lchojnack @mackierx111 @dmoszynski