Exit if pre-up hook exits non-zero #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrisbin
commented
Dec 29, 2022
pbrisbin
commented
Dec 29, 2022
mike-burns
reviewed
Dec 29, 2022
|
|
||
| if [ "$hook_ret" -ne 0 ]; then | ||
| echo "$when-$direction hook exited non-zero ($hook_ret)" >&2 | ||
| exit $hook_ret # NB. this only exits the while-read; caller must still check and exit |
There was a problem hiding this comment.
Whoa, that's good to know. Normally I don't love code comments but I definitely would have missed that quirk.
|
Sweet. Thanks for the quick review! Should be good to merge now. |
mike-burns
approved these changes
Dec 29, 2022
This allows scripts to bail early if a check fails.
mike-burns
force-pushed
the
pb/pre-up-failure
branch
from
88f6fc7 to
453e88b
Compare
|
Thanks. Also adding one for the down case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.