fix(keyboard): add brackets to defaultKeyMap (#1226)

testing-library · Jan 21, 2025 · 543ecb0 · 543ecb0
1 parent f0468d0
commit 543ecb0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/src/keyboard/keyMap.ts b/src/keyboard/keyMap.ts
@@ -4,7 +4,7 @@ import {DOM_KEY_LOCATION, keyboardKey} from '../system/keyboard'
  * Mapping for a default US-104-QWERTY keyboard
  */
 export const defaultKeyMap: keyboardKey[] = [
-  // alphanumeric keys
+  // alphanumeric block - writing system
   ...'0123456789'.split('').map(c => ({code: `Digit${c}`, key: c})),
   ...')!@#$%^&*('
     .split('')
@@ -16,6 +16,11 @@ export const defaultKeyMap: keyboardKey[] = [
     .split('')
     .map(c => ({code: `Key${c}`, key: c, shiftKey: true})),
 
+  {code: 'BracketLeft', key: '['},
+  {code: 'BracketLeft', key: '{', shiftKey: true},
+  {code: 'BracketRight', key: ']'},
+  {code: 'BracketRight', key: '}', shiftKey: true},
+
   // alphanumeric block - functional
   {code: 'Space', key: ' '},
 

diff --git a/tests/keyboard/parseKeyDef.ts b/tests/keyboard/parseKeyDef.ts
@@ -44,26 +44,26 @@ cases(
     },
     '{ as printable': {
       text: '{{',
-      keyDef: {key: '{', code: 'Unknown'},
+      keyDef: {key: '{', code: 'BracketLeft', shiftKey: true},
     },
     '{ as printable followed by descriptor': {
       text: '{{{foo}',
       keyDef: [
-        {key: '{', code: 'Unknown'},
+        {key: '{', code: 'BracketLeft', shiftKey: true},
         {key: 'foo', code: 'Unknown'},
       ],
     },
     '{ as key with modifiers': {
       text: '{\\{>5/}',
-      keyDef: {key: '{', code: 'Unknown'},
+      keyDef: {key: '{', code: 'BracketLeft', shiftKey: true},
     },
     'modifier as key with modifiers': {
       text: '{/\\/>5/}',
       keyDef: {key: '/', code: 'Unknown'},
     },
     '[ as printable': {
       text: '[[',
-      keyDef: {key: '[', code: 'Unknown'},
+      keyDef: {key: '[', code: 'BracketLeft'},
     },
   },
 )