Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG2-VALIDATION_COUNTRY_NOTEMPTY #42

Open
iDigBioBot opened this issue Jan 5, 2018 · 14 comments
Open

TG2-VALIDATION_COUNTRY_NOTEMPTY #42

iDigBioBot opened this issue Jan 5, 2018 · 14 comments
Labels
CODED Completeness CORE TG2 CORE tests SPACE Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation

Comments

@iDigBioBot
Copy link
Collaborator

iDigBioBot commented Jan 5, 2018

TestField Value
GUID 6ce2b2b4-6afe-4d13-82a0-390d31ade01c
Label VALIDATION_COUNTRY_NOTEMPTY
Description Is there a value in dwc:country?
TestType Validation
Darwin Core Class dcterms:Location
Information Elements ActedUpon dwc:country
Information Elements Consulted dwc:countryCode
Expected Response COMPLIANT if dwc:country is bdq:NotEmpty or dwc:countryCode has a value of "XZ" and either dwc:country is bdq:Empty or has a value of "High seas"; otherwise NOT_COMPLIANT ?
Data Quality Dimension Completeness
Term-Actions COUNTRY_NOTEMPTY
Parameter(s)
Source Authority
Specification Last Updated 2024-09-27
Examples [dwc:country="Eswatini": Response.status=RUN_HAS_RESULT, Response.result=COMPLIANT, Response.comment="dwc:country is bdq:NotEmpty"]
[dwc:country="": Response.status=RUN_HAS_RESULT, Response.result=NOT_COMPLIANT, Response.comment="dwc:country is bdq:Empty"]
Source
References
Example Implementations (Mechanisms) Kurator/FilteredPush geo_ref_qc Library DOI: 10.5281/zenodo.14064324
Link to Specification Source Code https://github.com/FilteredPush/geo_ref_qc/blob/v2.0.1/src/main/java/org/filteredpush/qc/georeference/DwCGeoRefDQ.java#L747
Notes Country is expected to be either bdq:Empty or ideally have a value of "High seas" or an agreed equivalent if material comes from the high seas, or from those portions of Antarctica outside of any sovereign nation.
@iDigBioBot
Copy link
Collaborator Author

Comment by Lee Belbin (@Tasilee) migrated from spreadsheet:
Added post scoring for consistency

@ArthurChapman ArthurChapman added the Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT label Jan 16, 2018
@ArthurChapman ArthurChapman changed the title TG2-VALIDATION_COUNTRY_NULL TG2-VALIDATION_COUNTRY_EMPTY Jan 29, 2018
@Tasilee Tasilee added Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. and removed Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT labels Mar 21, 2018
@pzermoglio pzermoglio added Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT and removed NEEDS WORK Supplementary Tests supplementary to the core test suite. These are tests that the team regarded as not CORE. labels Aug 25, 2018
@tucotuco
Copy link
Member

Agreed at TDWG 2018 DQIG meeting that the original assessment of the core nature of the test was correct based on consistency with other tests and participation in dependencies for other tests.

ArthurChapman added a commit that referenced this issue Oct 8, 2020
In accord with #189 added test data file for #42
@Tasilee Tasilee changed the title TG2-VALIDATION_COUNTRY_EMPTY TG2-VALIDATION_COUNTRY_NOTEMPTY Mar 22, 2022
chicoreus added a commit to FilteredPush/geo_ref_qc that referenced this issue Sep 2, 2022
chicoreus added a commit to FilteredPush/geo_ref_qc that referenced this issue Jun 12, 2023
…st current (2023-06-09) SPACE test descriptions. Adding ProvidesVersion (and Specification) annotations. Removing now empty file stubs for checked methods. Addressed tdwg/bdq#42 VALIDATION_COUNTRY_NOTEMPTY
@Tasilee
Copy link
Collaborator

Tasilee commented Sep 16, 2023

Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted". Also changed "Fields" to "TestField" and "Output Type" to "TestType".

@chicoreus chicoreus added the CORE TG2 CORE tests label Sep 18, 2023
@chicoreus
Copy link
Collaborator

Added comment "Country is expected to be empty if material comes from the high seas, or from those portions of Antartica outside of any sovereign nation." from duplicate #223.

@Tasilee
Copy link
Collaborator

Tasilee commented Sep 25, 2024

Corrected spelling of "Antarctica" in Notes.

Also: This test is an equivalent to #98 in returning NOT_COMPLIANT for records outside national jurisdictions ('high seas') where dwc:country is rightly bdq:Empty. The point is that we may be reducing 'quality' with valid 'high seas' records. The marine community may not be amused.

We need to handle these two tests similarly.

@ArthurChapman
Copy link
Collaborator

As I commented on under #98. This test - like all other tests for NOTEMPTY - is only checking if there is a value in that field - it makes no assumption on why it is empty. It is a simple YES/NO test.

@tucotuco
Copy link
Member

Corrected spelling of "Antarctica" in Notes.

Also: This test is an equivalent to #98 in returning NOT_COMPLIANT for records outside national jurisdictions ('high seas') where dwc:country is rightly bdq:Empty. The point is that we may be reducing 'quality' with valid 'high seas' records. The marine community may not be amused.

We are not reducing quality. We are providing an alert in contexts where such an alert is likely to be useful. The marine community would not use the test in contexts where it is not useful, so they should not have cause to not be amused.

@Tasilee
Copy link
Collaborator

Tasilee commented Sep 25, 2024

@tucotuco: Fair comment, but by the criterion that our tests are 'widely applicable', I would say that that this test, #62 and #98 are candidates for Supplementary - to be used in a more specific context?

@ArthurChapman
Copy link
Collaborator

I don't see how these NOTEMPTY tests are different from any other NOTEMPTY tests. I see them as valuable tests

@tucotuco
Copy link
Member

...and still widely aplicable.

@chicoreus
Copy link
Collaborator

chicoreus commented Sep 26, 2024 via email

@Tasilee
Copy link
Collaborator

Tasilee commented Sep 26, 2024

I agree @chicoreus. Given your second point above, should we be aspirational here (and #98) by adding something like INTERNAL_PREREQUISITES_NOT_MET if dwc:country equals "high seas" or contains "seas" or something that won't find a country match... and, "XZ" in the case of #98?

@chicoreus
Copy link
Collaborator

chicoreus commented Sep 26, 2024 via email

@Tasilee
Copy link
Collaborator

Tasilee commented Sep 27, 2024

Thanks @chicoreus - I think we are pretty much aligned. How about changing the Expected Response from

COMPLIANT if dwc:country is bdq:NotEmpty; otherwise NOT_COMPLIANT

to

COMPLIANT if dwc:country is bdq:NotEmpty or dwc:countryCode has a value of "XZ" and either dwc:country is bdq:Empty or has a value of "High seas"; otherwise NOT_COMPLIANT ?

I will also changes the Notes for both issues to something like

Country is expected to be either bdq:Empty or ideally have a value of "High seas" or an agreed equivalent if material comes from the high seas, or from those portions of Antarctica outside of any sovereign nation.

I will also, if agreed on the ER, add dwc:countryCode to the Information Elements Consulted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CODED Completeness CORE TG2 CORE tests SPACE Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation
Projects
None yet
Development

No branches or pull requests

6 participants