Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TG2-VALIDATION_MAXDEPTH_INRANGE #187

Open
Tasilee opened this issue Aug 26, 2020 · 13 comments
Open

TG2-VALIDATION_MAXDEPTH_INRANGE #187

Tasilee opened this issue Aug 26, 2020 · 13 comments
Labels
CODED Conformance CORE TG2 CORE tests Parameterized Test requires a parameter SPACE Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation

Comments

@Tasilee
Copy link
Collaborator

Tasilee commented Aug 26, 2020 •
edited by chicoreus
Loading

TestField Value
GUID 3f1db29a-bfa5-40db-9fd1-fde020d81939
Label VALIDATION_MAXDEPTH_INRANGE
Description Is the value of dwc:maximumDepthInMeters within the Parameter range?
TestType Validation
Darwin Core Class dcterms:Location
Information Elements ActedUpon dwc:maximumDepthInMeters
Information Elements Consulted
Expected Response INTERNAL_PREREQUISITES_NOT_MET if dwc:maximumDepthInMeters is bdq:Empty or is not interpretable as a number greater than or equal to zero; COMPLIANT if the value of dwc:maximumDepthInMeters is within the range of bdq:minimumValidDepthInMeters to bdq:maximumValidDepthInMeters inclusive; otherwise NOT_COMPLIANT
Data Quality Dimension Conformance
Term-Actions MAXDEPTH_INRANGE
Parameter(s) bdq:minimumValidDepthInMeters
bdq:maximumValidDepthInMeters
Source Authority bdq:minimumValidDepthInMeters default="0"
bdq:maximumValidDepthInMeters default="11000"
Specification Last Updated 2023-09-18
Examples [dwc:maximumDepthInMeters="1200": Response.status=RUN_HAS_RESULT, Response.result=COMPLIANT, Response.comment="dwc:maximumDepthInMeters is in range (<11,000)"]
[dwc:maximumDepthInMeters="99999": Response.status=RUN_HAS_RESULT, Response.result=NOT_COMPLIANT, Response.comment="dwc:maximumDepthInMeters is not in range (>11,000)"]
Source ALA, GBIF
References
Example Implementations (Mechanisms) Kurator/FilteredPush geo_ref_qc Library DOI: 10.5281/zenodo.14064324
Link to Specification Source Code https://github.com/FilteredPush/geo_ref_qc/blob/v2.0.1/src/main/java/org/filteredpush/qc/georeference/DwCGeoRefDQ.java#L2726
Notes The Challenger Deep in the Mariana Trench is the deepest known point in Earth's oceans at 10,994 meters. We have rounded up bdq:maximumValidDepthInMeters.
@Tasilee Tasilee closed this as completed Aug 26, 2020
@Tasilee Tasilee reopened this Aug 26, 2020
@Tasilee Tasilee added Conformance Parameterized Test requires a parameter SPACE Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation labels Aug 26, 2020
@Tasilee
Copy link
Collaborator Author

Tasilee commented Aug 26, 2020

This test was added after examining #107 that combined dwc:minimumDepthInMeters and dwc:maximumDepthInMeters in the one test and splitting it into the new #107 and this one.

@chicoreus
Copy link
Collaborator

Added a guid.

@chicoreus
Copy link
Collaborator

Definition needs tuning, zero and negative numbers are hard coded into the internal prerequsities not met, regardless of parameter values. Zero end point ambigously treated as special case depending on interpretation of within. Suggest:

INTERNAL_PREREQUISITES_NOT_MET if dwc:maximumDepthInMeters is EMPTY or is not a number; COMPLIANT if the value of dwc:maximumDepthInMeters is within the Parameter range of bdq:minimumValidDepthInMeters to bdq:maximumValidDepthInMeters inclusive; otherwise NOT_COMPLIANT

This would make negative numbers not compliant, which makes sense, as negative numbers can be tested against the range, while strings or empty values cannot be tested.

@Tasilee
Copy link
Collaborator Author

Tasilee commented Sep 30, 2020

Thanks @chicoreus. I agree. We do have a definition of EMPTY BTW in our vocabulary: "A field that is either not present or does not contain any characters or values. Note: A field containing non-printing or other invalid characters or values (including NULL values) may be separately detected".

@Tasilee Tasilee mentioned this issue Sep 30, 2020
Closed
chicoreus added a commit that referenced this issue Oct 1, 2020
@chicoreus
Adding example test file to provide an example for #189 with test dat…
8eab115 
…a for #187.  Filename suggests pattern, testdata_{humanreadablenameoftest}.csv for such test data sets
chicoreus added a commit that referenced this issue Oct 1, 2020
@chicoreus
Updating test data and text comments for test data for example test d…
ce93b78 
…ata (#189) for test #187.
chicoreus added a commit that referenced this issue Oct 1, 2020
@chicoreus
Renaming file for example test data (#189) for test #187 to make file…
7c49bc0 
…name consistent with case of test label.
chicoreus added a commit that referenced this issue Oct 2, 2020
@chicoreus
Per discussion in #189 regarding best practice use of depth and eleva…
c9cddb9 
…tion, updating status and comment for negative values in test data for #187.
ArthurChapman added a commit that referenced this issue Oct 6, 2020
@ArthurChapman
Rename testdata_VALIDATION_MAXDEPTH_OUTOFRANGE.csv to testdata_VALIDA…
81bc7b2 
…TION_MAXDEPTH_OUTOFRANGE #187.csv
ArthurChapman added a commit that referenced this issue Oct 6, 2020
@ArthurChapman
Rename testdata_VALIDATION_MAXDEPTH_OUTOFRANGE #187.csv to testdata_V…
9ffae49 
…ALIDATION_MAXDEPTH_OUTOFRANGE_#187.csv
@tucotuco tucotuco mentioned this issue May 4, 2021
Closed
@albenson-usgs albenson-usgs mentioned this issue Nov 2, 2021
Open
@Tasilee Tasilee changed the title TG2-VALIDATION_MAXDEPTH_OUTOFRANGE TG2-VALIDATION_MAXDEPTH_INRANGE Mar 22, 2022
@ArthurChapman ArthurChapman mentioned this issue Mar 25, 2022
Open
@Tasilee Tasilee removed the NEEDS WORK label Apr 3, 2022
@Tasilee Tasilee mentioned this issue Apr 22, 2022
Open
@Tasilee
Copy link
Collaborator Author

Tasilee commented Jun 1, 2022

For consistency with #112, The Warning Type has been changed to "Unlikely"

@Tasilee
Copy link
Collaborator Author

Tasilee commented Jun 1, 2022

Changed decision from Zoom: Warning Type of this test and #112 should be "Invalid"

chicoreus added a commit to FilteredPush/geo_ref_qc that referenced this issue Aug 30, 2022
@chicoreus
Reorganizing tests and methods in line with other libraries. Adding D…
e2153a6 
…wcGeoFrefDQDefinitionsIT for integration tests that invoke remote servcies. Adding DwCGeoRefDQDefaults extends DwCGeoRefDQ to hold methods to be invoked with default parameter values. Moving validationMaxdepthOutofrange(maxDepth) to comply with this expectation. Updating the comments and annotations for validationMaxDepthOutOfRange to match current specifications in tdwg/bdq#187 and removing from stubs.
@chicoreus
Copy link
Collaborator

Needs alignment with #107 where @tucotuco argued persuasively that negative values should result in internal prerequsites not met, given the definition for the DarwinCore terms for depth and the presence of alternative terms for offset from baseline. #107 and #187 should treat -1 in the same way, currently they do not.

chicoreus added a commit to FilteredPush/geo_ref_qc that referenced this issue Sep 6, 2022
@chicoreus
Updating implementation (and test, naming, and comments) of tdwg/bdq#107
8620283 
 VALIDATION_MINDEPTH_INRANGE to match current specification.  Also aligning tdwg/bdq#187 VALIDATION_MAXDEPTH_INRANGE with the same rejection out of hand of negative values, though the current test specifications are inconsistent in these two cases.
@Tasilee
Copy link
Collaborator Author

Tasilee commented Sep 6, 2022

Done but do we need to similarly account for "0"?

@tucotuco
Copy link
Member

tucotuco commented Sep 7, 2022

@Tasilee Similarly how?

@Tasilee
Copy link
Collaborator Author

Tasilee commented Sep 7, 2022

As in

INTERNAL_PREREQUISITES_NOT_MET if dwc:maximumDepthInMeters is EMPTY or is not interpretable as zero or a positive number; COMPLIANT if the value of dwc:maximumDepthInMeters is within the range of bdq:minimumValidDepthInMeters to bdq:maximumValidDepthInMeters inclusive; otherwise NOT_COMPLIANT

@tucotuco
Copy link
Member

tucotuco commented Sep 8, 2022

Yes, good catch. Alternatively, "a number greater than or equal to zero"?

@Tasilee
Copy link
Collaborator Author

Tasilee commented Sep 8, 2022

Amended ER to

INTERNAL_PREREQUISITES_NOT_MET if dwc:maximumDepthInMeters is EMPTY or is not interpretable as a number greater than or equal to zero; COMPLIANT if the value of dwc:maximumDepthInMeters is within the range of bdq:minimumValidDepthInMeters to bdq:maximumValidDepthInMeters inclusive; otherwise NOT_COMPLIANT

@ymgan ymgan mentioned this issue Feb 15, 2023
Open
chicoreus added a commit to FilteredPush/geo_ref_qc that referenced this issue Jun 16, 2023
@chicoreus
Work in progress checking implementation of DwCEventDQ methods agains…
944d4be 
…t current (2023-06-12) test descriptions. Addressed implementation of tdwg/bdq#187 VALIDATION_MAXDEPTH_INRANGE   Adding ProvidesVersion annotations.   Removing now empty file stubs for checked methods.  Adding some unit tests.
@ymgan ymgan mentioned this issue Sep 13, 2023
Open
@Tasilee
Copy link
Collaborator Author

Tasilee commented Sep 18, 2023

Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted".

Also changed "Field" to "TestField", "Output Type" to "TestType" and updated "Specification Last Updated"

@chicoreus chicoreus added the CORE TG2 CORE tests label Sep 18, 2023
chicoreus added a commit to FilteredPush/geo_ref_qc that referenced this issue Nov 10, 2024
@chicoreus
Bringing more test metadata and implementation up to current specific…
c321d41 
…ations: tdwg/bdq#56 tdwg/bdq#59 tdwg/bdq#187, noting in 59 potential of change needed as specification does not conform to Darwin Core value (which may just need rationale management in the issue, or may need a change).
@chicoreus chicoreus added the CODED label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CODED Conformance CORE TG2 CORE tests Parameterized Test requires a parameter SPACE Test Tests created by TG2, either CORE, Supplementary or DO NOT IMPLEMENT TG2 Validation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tucotuco @chicoreus @Tasilee