We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vulnerability][acl] ACL is skipped for source objects in Object.assign()
Object.assign()
Object.assign({},window).caches;
S_TARGETED
diff --git a/demo/hook-callback.js b/demo/hook-callback.js index 7f0b54f3..5e29075c 100644 --- a/demo/hook-callback.js +++ b/demo/hook-callback.js @@ -4839,6 +4839,12 @@ else { if (_args[1][1] instanceof Object) { rawProperty = []; for (let i = 1; i < _args[1].length; i++) { + let _obj = _args[1][i]; + let _name = _globalObjects.get(_obj); + if (!applyAcl(_name, true, false, S_ALL, 'r', context, _obj, _args, arguments)) { + result = [_name, true, false, S_ALL, 'r', context, _obj, _args, arguments]; + throw new Error('Permission Denied: Cannot access ' + SetMap.getStringValues(_name)); + } // TODO: Are inherited properties targeted? rawProperty = rawProperty.concat(Object.keys(_args[1][i])); } @@ -6278,6 +6284,12 @@ else { if (_args[1][1] instanceof Object) { rawProperty = []; for (let i = 1; i < _args[1].length; i++) { + let _obj = _args[1][i]; + let _name = _globalObjects.get(_obj); + if (!applyAcl(_name, true, false, S_ALL, 'r', context, _obj, _args, arguments)) { + result = [_name, true, false, S_ALL, 'r', context, _obj, _args, arguments]; + throw new Error('Permission Denied: Cannot access ' + SetMap.getStringValues(_name)); + } // TODO: Are inherited properties targeted? rawProperty = rawProperty.concat(Object.keys(_args[1][i])); }
The text was updated successfully, but these errors were encountered:
[vulnerability][acl] Rebuild with Fix #324 Apply ACL for S_TARGETED n…
ebcbc3b
…ormalized properties with S_ALL normalized property
9ff53e8
0.4.0-alpha.3 [README] Update README for Fix #324 Apply ACL for S_TAR…
decc772
…GETED normalized properties with S_ALL normalized property
0.4.0-alpha.3 [vulnerability][acl] Fix #324 Apply ACL for source obje…
354a190
…cts in Object.assign()
No branches or pull requests
[vulnerability][acl] ACL is skipped for source objects in
Object.assign()
Root Cause
Exploit Code
Fix
S_TARGETED
normalizationThe text was updated successfully, but these errors were encountered: