Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Direct access to source codes is not blocked after the first blocked access #254

Closed
t2ym opened this issue Apr 29, 2018 · 2 comments
Closed

Direct access to source codes is not blocked after the first blocked access #254

t2ym opened this issue Apr 29, 2018 · 2 comments

Comments

@t2ym
Copy link
Owner

t2ym commented Apr 29, 2018 •
edited
Loading

Direct access to source codes is not blocked after the first blocked access

Root Cause

  • On detection of direct access to source codes, the app and the Service Worker shut down
  • After the Service Worker shutdown, there are no longer blocking mechanisms.

Fix

  • Do not unregister the running Service Worker after the app shutdown and the cache cleanup so that the Service Worker continues to block access to source codes

Notes

  • After the main page is redirected to about:blank, the Service Worker is suspended and inaccessible from Dev Tools.
  • On the next access to the Service Worker scope, it is activated again and blocks direct source code access if necessary
  • It may take some time for the Service Worker to suspend after the app shutdown
@t2ym t2ym closed this as completed in 8ab3c99 Apr 29, 2018
t2ym added a commit that referenced this issue Apr 29, 2018
@t2ym
[README] Fix #254. Block direct source code access even after the app…
418ed85 
… shutdown
@t2ym
Copy link
Owner Author

t2ym commented Apr 29, 2018

This issue is not fixed with 0.0.248

@t2ym t2ym reopened this Apr 29, 2018
@t2ym t2ym closed this as completed in ee5072a Apr 29, 2018
t2ym added a commit that referenced this issue Apr 29, 2018
@t2ym
[README] Additional Fix #254. Remove redundant actions on Dev Tools d…
35b2481 
…etection
t2ym added a commit that referenced this issue Apr 29, 2018
@t2ym
0.0.249 with Fix #254 Block direct access to source codes even after …
3f59426 
…the app shutdown
@t2ym
Copy link
Owner Author

t2ym commented Apr 29, 2018 •
edited
Loading

The fix with 0.0.249 still have some issues

  • Working in most cases

Root Cause

  • Request blocking configurations are lost after the browser restarts

@t2ym t2ym reopened this Apr 29, 2018
t2ym added a commit that referenced this issue Apr 29, 2018
@t2ym
[README] Additional Fix #254. Keep configurations.json in cache
7b6c159
@t2ym t2ym closed this as completed in fc2934e Apr 29, 2018
t2ym added a commit that referenced this issue Apr 29, 2018
@t2ym
0.0.250 with Fix #254 Block direct source code access even after the …
30fcc8f 
…app shutdown and browser restarts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@t2ym