fix: raw message encoding in TransferTransaction #853
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The message is not correctly encoded when creating a
TransferTransaction
withRawMessage
.The
Uint8Array
is encoded to a hex string duringRawMessage.create()
.Then in the
getMessageBuffer()
ofTransferTransaction
the hex string (considered as a plain utf-8 text string) is converted to hex string again.Also, an extra 0xFF byte is added at the beginning of the raw message.
Solution
RawMessage.payload
to hex inTransferTransaction.getMessageBuffer()
, since the payload is already in hex.