Update typescript examples #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segfaultxavi
force-pushed
the
update-ts-examples
branch
from
9268963 to
fcee01f
Compare
rg911
suggested changes
Dec 1, 2020
| @@ -28,11 +28,11 @@ const repositoryFactory = new RepositoryFactoryHttp(nodeUrl); | |||
| const restrictionHttp = repositoryFactory.createRestrictionAccountRepository(); | |||
|
|
|||
| restrictionHttp.getAccountRestrictions(address) | |||
| .subscribe((accountRestrictions) => { | |||
| .subscribe((accountRestrictions: any) => { | |||
There was a problem hiding this comment.
Could it be the actual type rather than any?
There was a problem hiding this comment.
What is the actual type? Typescript is still a bit obscure to me.
There was a problem hiding this comment.
so it should be the method's return type. AccountRestrictions
There was a problem hiding this comment.
I'm afraid my typescript is not strong enough. I have tried with AccountRestrictions and AccountRestrictions[] and both failed. Unless you give me more hints, I think I'll use any (which is what symbol-cli does).
There was a problem hiding this comment.
it should be AccountRestrictions as the ts sdk defined. what errors have you got?
There was a problem hiding this comment.
After changing any to AccountRestrictions and adding AccountRestrictions to the import line:
restriction/GettingAccountRestrictions.ts:32:29 - error TS2339: Property 'length' does not exist on type 'AccountRestrictions'.
32 if (accountRestrictions.length > 0) {
~~~~~~
restriction/GettingAccountRestrictions.ts:34:10 - error TS2339: Property 'filter' does not exist on type 'AccountRestrictions'.
34 .filter((accountRestriction: any) => accountRestriction.values.length > 0)
~~~~~~
source/resources/examples/typescript/aggregate/AddingCosignaturesAggregateComplete.ts
Outdated
Show resolved
Hide resolved
fboucquez
force-pushed
the
update-ts-examples
branch
from
7121b20 to
b8255c3
Compare
segfaultxavi
force-pushed
the
update-ts-examples
branch
9 times, most recently
from
0c417f3 to
76a01e3
Compare
Mostly adding epochAdjustment to all transaction.create() calls but there are a few other tweaks too.
Using async await instead of observable's methods for simplicity Removed hardcoded deadline, network type, generation hash, currency information Added eslint and prettier (but not exectued yet)
This is just the result of running "npm run style:fix". No functional changes.
Install node 12 Update sdk version to release 0.22.0 No functional changes.
segfaultxavi
force-pushed
the
update-ts-examples
branch
from
402a367 to
a3c3f47
Compare
So that all examples fit in the guides without requiring scrollbars, for any screen layout. Now this is enforced by Travis so there's no risk of breaking it in the future.
These are autogenerated using tsc for now.
segfaultxavi
force-pushed
the
update-ts-examples
branch
from
a3c3f47 to
faa9911
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly adding epochAdjustment to all transaction.create() calls
but there are a few other tweaks too.
Fixes #538