Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding korean in vision.rst #1048

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

karriz-dev
Copy link
Contributor

@segfaultxavi

As my first translation task, I tried the vision.rst file. I checked it with livehtml, but I think I need to check if I missed something. and I'll also talk about whether I can help the Korean community as well.

  • adding Korean in vision.rst

Issued by #741

@segfaultxavi
Copy link
Collaborator

I am no longer in charge of this repository. I think @orisdorch does now?

@Wayonb
Copy link
Contributor

Wayonb commented Nov 15, 2023

@karriz-dev Can you rebase your fork to the latest in main?

@karriz-dev
Copy link
Contributor Author

@Wayonb rebase completed 😄

@Wayonb
Copy link
Contributor

Wayonb commented Nov 16, 2023

@karriz-dev Thanks for rebase of the PR.
The only comment I have is that the notes refs in the document needs to be links. See the other langauges

@karriz-dev
Copy link
Contributor Author

@Wayonb Could you please tell me the line in vision.rst file? All the links in the ref I checked were operated normally. And I think it's the same when I check the documents in other languages ~!

@Wayonb
Copy link
Contributor

Wayonb commented Nov 19, 2023

@karriz-dev You are correct. I can see the links now. 👍🏾 Maybe browser issue 😅

Copy link
Contributor

@Wayonb Wayonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@Wayonb Wayonb merged commit 91b1c01 into symbol:main Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants