Fix collection update. Validation. Chunks #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OlegMakarenko
commented
Mar 30, 2021
•
OlegMakarenko
commented
- Improve db collections update transaction
- Added node model validation
- Node list splitted into the chunks and added delay of getting info
- Added initial node list into the loop
This was
linked to
issues
Mar 30, 2021
Closed
AnthonyLaw
reviewed
Mar 31, 2021
src/services/NodeMonitor.ts
Outdated
| ...nodeInfo.data, | ||
| host, | ||
| }); | ||
| } catch (e) {} |
There was a problem hiding this comment.
I think it may good to add logger.error inside the catch, at least we know which nodeUrl have an issue during the get request?
src/services/NodeMonitor.ts
Outdated
| private fetchNodesByURL = async (nodeUrl: string, includeCurrent: boolean = false): Promise<Array<INode>> => { | ||
| let nodeList = []; | ||
|
|
||
| if (includeCurrent === true) { |
There was a problem hiding this comment.
i think we can rename it to isIncludeCurrent
and if (isIncludeCurrent) will be enough?
AnthonyLaw
reviewed
Mar 31, 2021
AnthonyLaw
approved these changes
Mar 31, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.