[explorer/frontend]: project #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@OlegMakarenko, Can this PR be broken up into smaller ones? It would be easier to review. 😄 I will try to go through this one. |
…nslation files, add more button to block preview
…TextBox component
…dd mosaic avatars
…and update pagination hooks, add mosaic list, add TransactionDirection components
…added more transaction type icons, improved ValueTransactionType component
…es under single module
OlegMakarenko
force-pushed
the
explorer-frontend/project
branch
2 times, most recently
from
5b60465 to
018deee
Compare
[explorer/frontend] fix: remove scripts with wrong permissions [explorer/frontend] fix: add scripts [explorer/frontend]: fix permission issue
OlegMakarenko
force-pushed
the
explorer-frontend/project
branch
from
5727fe4 to
bede863
Compare
OlegMakarenko
force-pushed
the
explorer-frontend/project
branch
from
bede863 to
2361e25
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## explorer-frontend/dev #974 +/- ##
=========================================================
+ Coverage 98.20% 98.40% +0.19%
=========================================================
Files 156 68 -88
Lines 6407 1564 -4843
Branches 143 253 +110
=========================================================
- Hits 6292 1539 -4753
+ Misses 115 25 -90
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Wayonb
requested changes
Jun 28, 2024
explorer/frontend/api/blocks.js
Outdated
| totalFee: data.totalFees, | ||
| transactionCount: data.totalTransactions, | ||
| difficulty: ((data.difficulty / Math.pow(10, 14)) * 100).toFixed(2), | ||
| averageFee: data.totalTransactions ? truncateDecimals(data.totalFees / data.totalTransactions, config.NATIVE_MOSAIC_DIVISIBILITY) : 0 |
There was a problem hiding this comment.
What's the use case for the average fee?
There was a problem hiding this comment.
The average fee field was included in the finalized mockups in Figma. Its purpose was to display the average transaction fee at each time point (block height). However, for NEM, this information isn't particularly useful. I've removed the field. Thanks for pointing it out!
There was a problem hiding this comment.
Please verify the @0x6861746366574 to see if it's needed before you remove it. I was just curious.
|
@Wayonb Thanks, I've pushed the changes. |
Wayonb
requested changes
Jul 2, 2024
Wayonb
requested changes
Jul 4, 2024
OlegMakarenko
added a commit
that referenced
this pull request
Nov 5, 2024
Problem: There is no frontend project for NEM Explorer. Solution: - Setup Next.js project. - Add Jenkinsfile and Dockerfile. - Add lint and test configuration. - Add styles. - Add pages: 1. Home 2. Account List. 3. Account Info. 4. Block List. 5. Block Info. 6. Mosaic List. 7. Mosaic Info. 8. Namespace List. 9. Namespace Info. 10. Transaction List. 11. Transaction Info. 12. Error 404. 13. Error 500. - Add services for API communication. - Add utils. - Add reusable UI components. - Add tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo: https://nem-explorer.vercel.app/
Problem
Solution