[explorer/nodewatch]: Added query params for get node list endpoint #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLaw
changed the title
AnthonyLaw
force-pushed
the
nodewatch/node-filter
branch
from
e16e99b to
30afd3e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## nodewatch/add-node-api-status #1303 +/- ##
=================================================================
- Coverage 98.24% 98.24% -0.01%
=================================================================
Files 158 158
Lines 6571 6592 +21
Branches 143 143
=================================================================
+ Hits 6456 6476 +20
- Misses 115 116 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Wayonb
requested changes
Mar 12, 2025
| role_condition = True | ||
|
|
||
| if role is not None: | ||
| role_condition = role == descriptor.roles if exact_match else role == (role & descriptor.roles) |
There was a problem hiding this comment.
If the roles does not match, it seems you can return False
| role_condition = role == descriptor.roles if exact_match else role == (role & descriptor.roles) | ||
|
|
||
| if only_ssl: | ||
| return role_condition and descriptor.is_ssl_enabled |
There was a problem hiding this comment.
Should be able to do this return descriptor.is_ssl_enabled if only_ssl else True
| def _get_json_nodes(role, exact_match, request_args): | ||
| only_ssl = None | ||
| if 'only_ssl' in request_args: | ||
| only_ssl = True |
There was a problem hiding this comment.
only_ssl = True if 'only_ssl' in request_args else None
| limit = int(request_args.get('limit', 0)) | ||
|
|
||
| return jsonify(symbol_routes_facade.json_nodes(role=role, exact_match=exact_match, only_ssl=only_ssl, limit=limit, order=order)) | ||
|
|
There was a problem hiding this comment.
It seems role is always a required arg?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The filter node is missing on the API node list endpoint.
Solution: Added query params
only_ssl,limit, andorder.only_ssl: to filter out SSL enable node, it needs explorer and wallet.limit: the number of numbers returned from the endpoint.order: shuffle node list when required