Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[explorer/nodewatch]: added api node status field #1297

Open
wants to merge 2 commits into
base: nodewatch/statistics-service-migration
Choose a base branch
from

Conversation

AnthonyLaw
Copy link
Member

Problem: The API node status field is missing.
Solution: Added API node status properties in NodeDescriptor.

@AnthonyLaw AnthonyLaw requested review from Wayonb and Jaguar0625 March 8, 2025 00:07
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.24%. Comparing base (36b0577) to head (4ad67d2).

Additional details and impacted files

Impacted file tree graph

@@                           Coverage Diff                           @@
##           nodewatch/statistics-service-migration    #1297   +/-   ##
=======================================================================
  Coverage                                   98.24%   98.24%           
=======================================================================
  Files                                         158      158           
  Lines                                        6560     6571   +11     
  Branches                                      143      143           
=======================================================================
+ Hits                                         6445     6456   +11     
  Misses                                        115      115           
Flag Coverage Δ
explorer-nodewatch 98.52% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
explorer/nodewatch/nodewatch/NetworkRepository.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@Wayonb Wayonb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants