Improve path merging for non-filled paths #1312
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi please rebase and add tests |
|
@yGuy Any update on this? Sounds promising and would be good to get it merged in. |
|
Sorry, no time for this, right now. But anyone can rebase and add tests. It doesn't have to be me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If two paths are not filled, it does not matter whether they intersect or not and they can be merged. This helps with the common case of many different "lines" (which have no fill) that will fail to be merged if they intersect, which is common in many graphics.
With this change many of my files I got another 10% size reduction, because path merging almost always failed for my non-filled paths in "crowded" svgs..