Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency cookie to ^0.7.0 [security] #12768

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 7, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
cookie ^0.6.0 -> ^0.7.0 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-47764

Impact

The cookie name could be used to set other fields of the cookie, resulting in an unexpected cookie value. For example, serialize("userName=<script>alert('XSS3')</script>; Max-Age=2592000; a", value) would result in "userName=<script>alert('XSS3')</script>; Max-Age=2592000; a=test", setting userName cookie to <script> and ignoring value.

A similar escape can be used for path and domain, which could be abused to alter other fields of the cookie.

Patches

Upgrade to 0.7.0, which updates the validation for name, path, and domain.

Workarounds

Avoid passing untrusted or arbitrary values for these fields, ensure they are set by the application instead of user input.

References


Release Notes

jshttp/cookie (cookie)

v0.7.0: 0.7.0

Compare Source


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

changeset-bot bot commented Oct 7, 2024

⚠️ No Changeset found

Latest commit: 3ada729

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@eltigerchino
Copy link
Member

eltigerchino commented Oct 9, 2024

Note: the new version of the cookie parser adheres more strictly to the RFC which will prevent cookie names from containing : , etc. causing it to be a breaking change.

@derkbell
Copy link

Any ETA on this or can I help on getting this merged? I have a failing CI audit check because of the cookie vulnerability

@eltigerchino
Copy link
Member

Any ETA on this or can I help on getting this merged? I have a failing CI audit check because of the cookie vulnerability

You'll need to use an override to install cookie 0.7.0 since we can't merge this without it being a breaking change. You'll have to wait until SvelteKit 3 or if we can find another workaround.

@derkbell
Copy link

Thanks for your swift reply, I didn't know about the overrides, learned something new today. This works for now.

@renovate renovate bot force-pushed the renovate/npm-cookie-vulnerability branch from fa27e2a to d7f6f72 Compare October 22, 2024 19:09
dae added a commit to ankitects/anki that referenced this pull request Oct 26, 2024
Sveltekit won't update until 3.0

sveltejs/kit#12768
@renovate renovate bot force-pushed the renovate/npm-cookie-vulnerability branch from d7f6f72 to 912fe69 Compare November 1, 2024 16:12
@renovate renovate bot force-pushed the renovate/npm-cookie-vulnerability branch from 912fe69 to 3ada729 Compare November 12, 2024 16:31
@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-kit-12768-svelte.vercel.app/

this is an automated message

@elikoga
Copy link
Contributor

elikoga commented Jan 26, 2025

They released cookie v1

Now is a good time to revive this and make the breaking change

cookie v1.0.2 loosened the restrictions.

https://github.com/jshttp/cookie/pull/210/files#diff-5634da488288c9045d2eb8425e64076d2c19211aefe3e531ca0087f3ab7794d0R38

updating to v1 is no longer breaking, only the version range 0.7.0-1.0.1 is bad

@eltigerchino
Copy link
Member

duplicate of #13386

Copy link
Contributor Author

renovate bot commented Jan 31, 2025

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (^0.7.0). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/npm-cookie-vulnerability branch January 31, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants