-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency cookie to ^0.7.0 [security] #12768
Conversation
|
Note: the new version of the cookie parser adheres more strictly to the RFC which will prevent cookie names from containing |
Any ETA on this or can I help on getting this merged? I have a failing CI audit check because of the cookie vulnerability |
You'll need to use an override to install cookie 0.7.0 since we can't merge this without it being a breaking change. You'll have to wait until SvelteKit 3 or if we can find another workaround. |
Thanks for your swift reply, I didn't know about the overrides, learned something new today. This works for now. |
fa27e2a
to
d7f6f72
Compare
Sveltekit won't update until 3.0 sveltejs/kit#12768
d7f6f72
to
912fe69
Compare
912fe69
to
3ada729
Compare
preview: https://svelte-dev-git-preview-kit-12768-svelte.vercel.app/ this is an automated message |
They released cookie v1
cookie v1.0.2 loosened the restrictions. updating to v1 is no longer breaking, only the version range 0.7.0-1.0.1 is bad |
duplicate of #13386 |
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update ( If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
^0.6.0
->^0.7.0
GitHub Vulnerability Alerts
CVE-2024-47764
Impact
The cookie name could be used to set other fields of the cookie, resulting in an unexpected cookie value. For example,
serialize("userName=<script>alert('XSS3')</script>; Max-Age=2592000; a", value)
would result in"userName=<script>alert('XSS3')</script>; Max-Age=2592000; a=test"
, settinguserName
cookie to<script>
and ignoringvalue
.A similar escape can be used for
path
anddomain
, which could be abused to alter other fields of the cookie.Patches
Upgrade to 0.7.0, which updates the validation for
name
,path
, anddomain
.Workarounds
Avoid passing untrusted or arbitrary values for these fields, ensure they are set by the application instead of user input.
References
Release Notes
jshttp/cookie (cookie)
v0.7.0
: 0.7.0Compare Source
main
topackage.json
for rspack (#166 by @proudparrot2)Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.