add justfile, update readme, remove coveralls #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavdid-stripe
requested review from
a team and
helenye-stripe
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
In an effort to modernize and simplify our local tooling, we're moving our dev commands from makefiles to justfiles. This is intended to be mostly a drop-in replacement, but some command names may change per standardization efforts.
As part of simplifying the CI, I removed the
Makefileandtoxsetup (since I had tweaked everything too far for them to be useful).What?
See Also
DEVSDK-2325
Why Not Tox?
toxis great at simultaneously managing multiple python versions, but we don't really do that much. GH Actions handles versions in CI and locally we all just work off the same one version (and mise can swap us if we need). So our pattern of make -> tox -> pytest (/ other tools) was way harder to reason about that it needed to be.Instead, each tool uses whatever default
pythonis available and we ensure unit test coverage by switching out those versions. If we want to work/test against different versions locally, we manage our versions with mise and use the scripts to reset the env.