Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Add @angular-devkit/build-angular to installed packages #30790

Merged
merged 6 commits into from
Mar 11, 2025

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Mar 11, 2025

What I did

Add @angular-devkit/build-angular to default installed pacakages in angular. As it is not installed by default anymore by angular.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Added '@angular-devkit/build-angular' as a default package in the Angular generator for Storybook since it's no longer included by default in Angular installations.

  • Added @angular-devkit/build-angular to default packages in code/lib/create-storybook/src/generators/ANGULAR/index.ts
  • Maintains backward compatibility with existing Compodoc package handling
  • No breaking changes introduced

@kasperpeulen kasperpeulen added the ci:daily Run the CI jobs that normally run in the daily job. label Mar 11, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Mar 11, 2025

View your CI Pipeline Execution ↗ for commit 8a6b6ec.

Command Status Duration Result
nx affected -t check -c production --parallel=7 ✅ Succeeded <1s View ↗
nx run-many -t build -c production --parallel=3 ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-11 14:53:19 UTC

@kasperpeulen kasperpeulen added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Mar 11, 2025
@kasperpeulen kasperpeulen merged commit dd24af9 into next Mar 11, 2025
80 of 105 checks passed
@kasperpeulen kasperpeulen deleted the kasper/fix-prerelease branch March 11, 2025 15:03
@shilman shilman changed the title Angular: Add @angular-devkit/build-angular to default installed pacakages in angular Angular: Add @angular-devkit/build-angular to default installed packages Mar 12, 2025
@shilman shilman changed the title Angular: Add @angular-devkit/build-angular to default installed packages Angular: Add @angular-devkit/build-angular to installed packages Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:daily Run the CI jobs that normally run in the daily job. patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant