Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Move @storybook/addon-actions into storybook #30765

Draft
wants to merge 30 commits into
base: next
Choose a base branch
from

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Mar 6, 2025

Closes #

What I did

  • I have merged @storybook/addon-actions into storybook/actions
  • Consequently, I have removed @storybook/addon-actions from addon essentials
  • I have removed a bunch of obsolete codemods

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic changed the title Valentin/move addon actions into core Core: Move @storybook/addon-actions into storybook Mar 6, 2025
Copy link

nx-cloud bot commented Mar 6, 2025

View your CI Pipeline Execution ↗ for commit 4ad1929.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 55s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-12 11:47:09 UTC

Base automatically changed from valentin/move-lib-test-into-core to next March 7, 2025 13:12
@storybook-pr-benchmarking
Copy link

storybook-pr-benchmarking bot commented Mar 11, 2025

Package Benchmarks

Commit: 4ad1929, ran on 12 March 2025 at 11:51:48 UTC

The following packages have significant changes to their size or dependencies:

@storybook/addon-essentials

Before After Difference
Dependency count 32 26 🎉 -6 🎉
Self size 18 KB 17 KB 🎉 -1 KB 🎉
Dependency size 15.55 MB 12.28 MB 🎉 -3.27 MB 🎉
Bundle Size Analyzer Link Link

storybook

Before After Difference
Dependency count 98 102 🚨 +4 🚨
Self size 21.54 MB 21.00 MB 🎉 -547 KB 🎉
Dependency size 21.69 MB 24.62 MB 🚨 +2.93 MB 🚨
Bundle Size Analyzer Link Link

@storybook/sveltekit

Before After Difference
Dependency count 139 132 🎉 -7 🎉
Self size 100 KB 100 KB 🎉 -106 B 🎉
Dependency size 39.90 MB 36.62 MB 🎉 -3.28 MB 🎉
Bundle Size Analyzer Link Link

sb

Before After Difference
Dependency count 99 103 🚨 +4 🚨
Self size 1 KB 1 KB 0 B
Dependency size 43.24 MB 45.62 MB 🚨 +2.38 MB 🚨
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 388 392 🚨 +4 🚨
Self size 284 KB 284 KB 🚨 +47 B 🚨
Dependency size 93.39 MB 95.59 MB 🚨 +2.20 MB 🚨
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 309 313 🚨 +4 🚨
Self size 614 KB 31 KB 🎉 -583 KB 🎉
Dependency size 74.99 MB 77.38 MB 🚨 +2.38 MB 🚨
Bundle Size Analyzer Link Link

create-storybook

Before After Difference
Dependency count 7 7 0
Self size 10.29 MB 10.68 MB 🚨 +398 KB 🚨
Dependency size 2.24 MB 2.24 MB 0 B
Bundle Size Analyzer Link Link

@valentinpalkovic valentinpalkovic added ci:merged Run the CI jobs that normally run when merged. and removed ci:normal labels Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: actions ci:merged Run the CI jobs that normally run when merged. core maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants