Core: Replace 'min' instead of 'm' in printDuration #30668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
LGTM
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Package BenchmarksCommit: No significant changes detected, all good. 👏 |
|
View your CI Pipeline Execution ↗ for commit d442866.
☁️ Nx Cloud last updated this comment at |
valentinpalkovic
changed the title
There was a problem hiding this comment.
LGTM
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
18 tasks
shilman
added
the
patch:yes
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Changes the string to replace in
printDurationfrom' m'to' min'. TheprettyTimefunction frompretty-hrtimeuses the suffix'min'rather than'm'; as a result,printDurationcurrently prints times like:rather than:
Testing
Manual testing
We could probably add some unit tests for this, but I'm not sure it's worth it. Testing it manually probably requires running on a project that takes somewhere on the order of minutes to load and checking that the message looks correct.
Greptile Summary
Fixed incorrect duration formatting in the
printDurationutility function to properly display time units in build progress messages.code/core/src/common/utils/print-duration.tsfrom' m'to' min'to matchpretty-hrtimeoutput format💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!