Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanups and fixes to maintenance #4657

Merged
merged 4 commits into from
Mar 1, 2025
Merged

Cleanups and fixes to maintenance #4657

merged 4 commits into from
Mar 1, 2025

Conversation

marta-lokhova
Copy link
Contributor

Only the last commit has functional changes, which are fixes to maintenance introduced by #4543. Changes are as follows, by commit:

  • Resolves drop LOCAL_BUCKETS_ONLY Catchup mode #4586
  • Remove an old history mode which became obsolete after in-memory got removed
  • Cleanup various interfaces, there were several unused variables
  • Two main changes are: (1) restore maintenance of SCP history, which got removed by accident, and (2) run ledger header maintenance on the ledger close thread to avoid potential serialization conflicts during ledger close.

@marta-lokhova marta-lokhova force-pushed the maintenance_and_cleanup branch from 4435c55 to f7c0d13 Compare February 28, 2025 19:02
SirTyson
SirTyson previously approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@SirTyson SirTyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marta-lokhova marta-lokhova force-pushed the maintenance_and_cleanup branch from f7c0d13 to e53616a Compare February 28, 2025 21:57
@marta-lokhova marta-lokhova force-pushed the maintenance_and_cleanup branch from e53616a to e9fa98b Compare February 28, 2025 22:56
@marta-lokhova marta-lokhova added this pull request to the merge queue Mar 1, 2025
Merged via the queue into stellar:master with commit 69cb5cb Mar 1, 2025
13 checks passed
@marta-lokhova marta-lokhova deleted the maintenance_and_cleanup branch March 1, 2025 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirTyson SirTyson SirTyson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

drop LOCAL_BUCKETS_ONLY Catchup mode
2 participants
@marta-lokhova @SirTyson