Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden bloom filter vector access #4619

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Harden bloom filter vector access #4619

merged 1 commit into from
Jan 10, 2025

Conversation

SirTyson
Copy link
Contributor

Description

Resolves #4618

This hardens Binary Fuse Filter constructor code to use protected vector lookups instead of C style array dereferencing.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

@SirTyson SirTyson force-pushed the harden-bloom-filter branch from e440379 to 687e2dd Compare January 10, 2025 21:32
@SirTyson SirTyson added this pull request to the merge queue Jan 10, 2025
Merged via the queue into stellar:master with commit e82e15a Jan 10, 2025
13 checks passed
@SirTyson SirTyson deleted the harden-bloom-filter branch January 10, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marta-lokhova marta-lokhova marta-lokhova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Binary Fuse Filter memory access
2 participants
@SirTyson @marta-lokhova