Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend nomination monte carlo simulations to analyze timeouts #4574

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

bboston7
Copy link
Contributor

Description

Closes #4561

This change adds a couple more tests to the nomination tests for the following scenarios:

  1. Asymmetric quorums
  2. Unresponsive validators

It also removes some protocol gating in the test suite that's no longer necessary now that P22 is the current protocol in the build.

Checklist

  • Reviewed the contributing document
  • Rebased on top of master (no merge commits)
  • Ran clang-format v8.0.0 (via make format or the Visual Studio extension)
  • Compiles
  • Ran all tests
  • If change impacts performance, include supporting evidence per the performance document

Closes stellar#4561

This change adds a couple more tests to the nomination tests for the
following scenarios:
1. Asymmetric quorums
2. Unresponsive validators

It also removes some protocol gating in the test suite that's no longer
necessary now that P22 is the current protocol in the build.
Copy link
Contributor

@marta-lokhova marta-lokhova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@marta-lokhova marta-lokhova added this pull request to the merge queue Dec 17, 2024
Merged via the queue into stellar:master with commit 0e19194 Dec 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend nomination Monte Carlo simulations to cover asymmetric quorums
2 participants