support mixed http-01 and dns-01 challenges #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for certificates that requires both the dns-01 and http-01 challenge. I think this is fairly common, when you want a cert that works for both
*.yoursite.com
as well as justyoursite.com
. As far as I can tell, it's Let's Encrypt's ACME server that decides whether to give us a dns-01 challenge, or http-01 challenge. In the case of*.yoursite.com,yoursite.com
, from what I observed it will first require a dns-01 challenge for*.yoursite.com
, and then a http-01 challenge foryoursite.com
.Also tried to reduce the line count a little bit by pulling back out the
keyauthorization = ...
-lines that are common for both http-01 and dns-01. This gets the line count down from 225 to 217. Still quite a bit higher than diafygi's 198, and he has stated that one of the project goals is to stay below 200 lines. So this might be a show stopper.Suggesting to rename
--challenge-script
to--dns-01-script
, so its purpose is clearer, since it's only ever used for the dns-01 challenge. If a new challenges comes up in the future, the script calling signature will probably need to be different anyway.Added
--txtrecord
to the signature of the script being called, for consistency.Switched to using
_cmd
instead ofsubprocess.call
, to try to better fit into diafygi's code style.Added some instructions to README.md.