Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): update microbundle, publish source maps #1776

Merged
merged 4 commits into from
Mar 8, 2022

Conversation

fvsch
Copy link
Contributor

@fvsch fvsch commented Mar 8, 2022

  • Adds a description to our @stackblitz/sdk package.
  • Updates microbundle, the all-in-one tool we use to build our SDK into consumable typings and bundles.
  • Replaces the two-step tsc+microbundle build with just microbundle, no intermediary output directory needed.
  • Publish source maps, which can be useful for consumer of the package when debugging an error happening in the package (e.g. using DevTools) (since we only publish minified JS code).

@fvsch fvsch requested review from sulco and ggdaltoso March 8, 2022 13:24
Copy link
Contributor

@ggdaltoso ggdaltoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@@ -1,26 +1,26 @@
{
"name": "@stackblitz/sdk",
"version": "1.6.0",
"description": "",
"description": "SDK for generating and embedding StackBlitz projects.",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sulco Does this description work?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might imply that embedding is the only thing you can do to the generated project, but tbh I'm not sure how we could rephrase it without sounding clunky

@ggdaltoso ggdaltoso changed the title chore(sdk): udate microbundle, publish source maps chore(sdk): update microbundle, publish source maps Mar 8, 2022
@fvsch fvsch merged commit 97fc6ef into main Mar 8, 2022
@fvsch fvsch deleted the fvsch/sdk-tooling-update branch March 31, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants