sdk 1.5.4: explicitly allow node template, ignore project tags #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricSimons
reviewed
Jan 19, 2022
fvsch
force-pushed
the
fvsch/sdk-1-5-4
branch
from
3d29c65 to
10e90f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
'node'template type for projects, which avoids logging a warning in the console for our users which are already using it.Improve theProject['template']type to list all valid template names (vs just usingstring).tagsdata in POST request (we are deprecating it on the backend). The type remains to avoid breaking TypeScript builds for customers, but theProject['tags']property is marked as deprecated using JSDoc.Housekeeping:
docsfolder which had old content (if we regenerate docs, they change quite a bit, which hints at this folder not being maintained).gitignore, removed.vscodeconfig, added.prettierrc(but haven't reformatted everything to limit noise)