fix: import folder filtering #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just tested, thanks for fixing, it does improve things, merging after checks run |
JJ-Dynamite
pushed a commit
to val-x/valenClient
that referenced
this pull request
Jan 29, 2025
…mport-button fix: import folder filtering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I was trying to play around with some repos from projects I don't host in github. So I tried using the Import folder button and noticed It was loading files from folders that should be ignored so I took a little time to check and saw the function was almost there just needed to be moved.
Also the removed the folder name before sending to shouldIncludeFile so the IGNORE_PATTERNS wroked.