Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/UI enhancements #708

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

SujalXplores
Copy link

@SujalXplores SujalXplores commented Dec 13, 2024

📝 PR Checklist

  • Branch from the main branch
  • Update documentation if needed
  • Manually verify all new functionality works as expected
  • Keep PRs focused and atomic

This pull request includes several changes to the app/components/chat directory, focusing on UI improvements and code cleanup. The most important changes are listed below:

UI Improvements:

Current:

image

After:

image

Reason for Change
Observe the flash when we focus on prompt textarea.

2024-12-13.mp4

Code Cleanup:

Reason for Change
The tooltip was removed because:

  1. It provided no additional information beyond the button text ("Clone a Git Repo")
  2. Other sibling buttons in the component don't use tooltips, making this more consistent with the UI pattern
  3. Follows the principle of avoiding redundant ARIA/accessibility attributes when they don't add value

@SujalXplores
Copy link
Author

@thecodacus @dustinwloring1988 Could you please review these changes? Let me know if you'd like me to make any adjustments.

@thecodacus
Copy link
Collaborator

looks good to me thanks.

@thecodacus thecodacus merged commit fe3889b into stackblitz-labs:main Dec 13, 2024
2 checks passed
@SujalXplores SujalXplores deleted the fix/ui-enhancements branch December 13, 2024 19:29
JJ-Dynamite pushed a commit to val-x/valenClient that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants