Allow custom build of Flow ApplicationContext. #111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rstoyanchev
pushed a commit
that referenced
this pull request
Jul 15, 2022
This allows a custom build of the Flow ApplicationContext. See gh-111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first (possibly only, may have a second) PR from the Shibboleth Project that we'd like to see added to the milestone for SWF 3 that will help us eliminate some local duplication we needed, and I was able to shrink it down to a pretty simple and I think attractive change.
This just exposes a protected method on FlowModelFlowBuilder that allows the ApplicationContext to be custom-build by subclassing that one method. The default implementation just calls the pre-existing private methods that were being used originally.
This should be "subclasser-beware", obviously, it's understood that if you create your own context without considering what SWF does for itself, you're risking breakage.