#65 Add some MySQL documentation #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszarlinski
requested changes
Sep 14, 2018
README.md
Outdated
| Note that whenever the database type is changed, the data-access.properties file needs to be updated and the mysql-connector-java artifact from the pom.xml needs to be uncommented. | ||
| In its default configuration, Petclinic uses an in-memory database (HSQLDB) which gets populated at startup with data. | ||
| A similar setup is provided for MySql in case a persistent database configuration is needed. | ||
| Dependency for Connector/J, the MySQL JDBC driver is already included in the `dpom.xml` files. |
README.md
Outdated
| ### Use the Spring 'mysql' profile | ||
|
|
||
| To use a MySQL database, you have to start 3 microservices (`visits-service`, `customers-service` and `vets-services`) | ||
| with the `mysql` Spring profile. Add the `--spring.profiles.active=mysql`` as programm argument. |
There was a problem hiding this comment.
Fix. Thanks for the review.
mszarlinski
approved these changes
Sep 23, 2018
talha-01
pushed a commit
to talha-01/microservices-ci-cd-pipeline-with-petclinic-app
that referenced
this pull request
Nov 13, 2020
* spring-petclinic#65 Add some MySQL documentation * spring-petclinic#65 Add some MySQL documentation : fixing typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some old txt files and put all the documentation into the readme.md
This PR required the changes spring-petclinic/spring-petclinic-microservices-config@0361c87 into the Config Repository.
A spring
mysqlprofile has been added.On my laptop, MySQL use is working when I start microservices at command line or through my IDE.
With Docker, the connection with the jdbc:mysql://localhost:3306/petclinic?useSSL=false fails. I suppose
localhostis not known by docker. Maybe we have to add an optional mysql database into the docker-compose file.