Upgrade to Spring Cloud Finchley #72 #80
Merged
+141
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 2.0.2, Sleuth 2.0.0.RC2, Zipkin Server 2.8.4
mszarlinski
requested changes
Jul 7, 2018
| @@ -27,19 +28,20 @@ | |||
| * @author Maciej Szarlinski | |||
| */ | |||
| @Data | |||
| @NoArgsConstructor | |||
There was a problem hiding this comment.
Why do we need no-args constructor?
There was a problem hiding this comment.
I don't remember why I have to add the @NoArgsConstructor annotation. I will try to remove it.
| @@ -74,7 +75,11 @@ public Owner findOwner(@PathVariable("ownerId") int ownerId) { | |||
| @PutMapping(value = "/{ownerId}") | |||
| @Monitored | |||
| public Owner updateOwner(@PathVariable("ownerId") int ownerId, @Valid @RequestBody Owner ownerRequest) { | |||
| final Owner ownerModel = ownerRepository.findOne(ownerId); | |||
| final Optional<Owner> owner = ownerRepository.findById(ownerId); | |||
|
|
||
|
|
||
| private Pet findPetById(int petId) { | ||
| Optional<Pet> pet = petRepository.findById(petId); |
|
Changes applied into the 50231b1 commit |
mszarlinski
approved these changes
Jul 14, 2018
|
@mszarlinski may I merge the Fishley branch into master? I've already done a release (and a tag) for the current master version. |
|
👍 |
talha-01
pushed a commit
to talha-01/microservices-ci-cd-pipeline-with-petclinic-app
that referenced
this pull request
Nov 13, 2020
…c#80) * spring-petclinic#72 Upgrade to Spring Cloud Finchley M9 * spring-petclinic#72 Upgrade to Spring Boot 2.0.1 * spring-petclinic#72 Remove @deprecated API usage * spring-petclinic#72 Upgrade to Spring Cloud Finchley RC2, Spring Boot 2.0.2, Sleuth 2.0.0.RC2, Zipkin Server 2.8.4 * spring-petclinic#72 Registering the index ViewController is no more required * For logging, implement the toString() method of the Pet entity * spring-petclinic#72 Upgrade to Spring Boot Admin 2.0.0 * spring-petclinic#72 Add @NoArgsConstructor required for Jackson deserialization * spring-petclinic#72 Upgrade to Spring Boot 2.0.3 * spring-petclinic#72 Upgrade to Spring Cloud Finchley RELEASE * Change Zipkin local host URL * spring-petclinic#72 changes requested by the @mszarlinski code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request upgrades the application to Spring Boot Finchley based on Spring Boot 2.
Local deployment is working.
Docker deployment is working.
By waiting a patch of Spring Boot 2, I have to add the below line into the application.yml of the spring-petclinic-microservices-config module:
For my point of view, the feature/Finchley branch is complete and could be merge into the master. branch. Are you ok?