Repair Zipkin Micrometer Tracing

[MarianConstantinMarica]

No description provided.

[arey]

It looks like this common configuration may be moved to the https://github.com/spring-petclinic/spring-petclinic-microservices-config/blob/main/application.yml
Are you agree?

[arey]

@MarianConstantinMarica did you see my comment?

[marcingrzejszczak]

I would add logging.pattern.level=%5p [${spring.application.name:},%X{traceId:-},%X{spanId:-}] property so that the tracing information is there in the logs and as @arey suggested I would move this config to the config repo. Other than that LGTM.

[arey]

Thanks for the review @marcingrzejszczak

[MarianConstantinMarica]

@arey I Moved the common configuration to server-config!

[arey]

Ok thank you @MarianConstantinMarica
This PR seems to be ready for merging

I saw the config PR spring-petclinic/spring-petclinic-microservices-config#19 and I posted a comment. I let you see.

[arey]

Thanks a lot @MarianConstantinMarica

[arey]

@MarianConstantinMarica with docker-compose I've got the following error:

customers-service    | org.springframework.web.client.ResourceAccessException: I/O error on POST request for "http://localhost:9411/api/v2/spans": Connect to http://localhost:9411 [localhost/127.0.0.1] failed: Connection refused
customers-service    |  at org.springframework.web.client.RestTemplate.createResourceAccessException(RestTemplate.java:888)
customers-service    |  at org.springframework.web.client.RestTemplate.doExecute(RestTemplate.java:868)

I suspect the localhost.
However, a GET http://localhost:8888/visits-service-docker.yml returns the expected URL: http://tracing-server:9411

spring:
  ...
  zipkin:
    baseUrl: http://tracing-server:9411

Did you have any idea?

[MarianConstantinMarica]

@arey I don't know why this happen, I will check and I will come back with an answer.