Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed expired jvm flag -XX:+UseCGroupMemoryLimitForHeap from trace service #128

Merged

Conversation

damc-dev
Copy link
Contributor

@damc-dev damc-dev commented Apr 23, 2019

It appears that the openzipkin/zipkin docker image in the docker hub was upgraded to Java 11 and the -XX:+UseCGroupMemoryLimitForHeap is no longer a valid option. I believe it just needs to be removed.
The startup error is

tracing-server       | Unrecognized VM option 'UseCGroupMemoryLimitForHeap'
tracing-server       | Error: Could not create the Java Virtual Machine.
tracing-server       | Error: A fatal exception has occurred. Program will exit.

@arey arey merged commit 4124445 into spring-petclinic:master Apr 23, 2019
@arey
Copy link
Member

arey commented Apr 23, 2019

Your're right: the Zikkin Docker image uses Java 11 from Google distroless: https://github.com/openzipkin/docker-zipkin/blob/master/zipkin/Dockerfile

@arey
Copy link
Member

arey commented Apr 23, 2019

Thank you @damc-dev

talha-01 pushed a commit to talha-01/microservices-ci-cd-pipeline-with-petclinic-app that referenced this pull request Nov 13, 2020
…nzipkin-jvm-args

Removed expired jvm flag -XX:+UseCGroupMemoryLimitForHeap from trace service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants