Update to jdk10/11 #104
Closed
Update to jdk10/11 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 1, 2018 10:48
kvncrw
commented
Oct 1, 2018
| @@ -39,7 +39,7 @@ | |||
| <docker.image.prefix>mszarlinski</docker.image.prefix> | |||
| <docker.image.exposed.port>9090</docker.image.exposed.port> | |||
| <docker.image.dockerfile.dir>${basedir}</docker.image.dockerfile.dir> | |||
| <docker.plugin.version>0.4.13</docker.plugin.version> | |||
| <docker.plugin.version>1.1.1</docker.plugin.version> | |||
There was a problem hiding this comment.
there was an attempt to fix the non-breaking docker build exception, didn't work, but I figured why not just keep it on the latest.
kvncrw
commented
Oct 1, 2018
| <plugin> | ||
| <groupId>org.hibernate.orm.tooling</groupId> | ||
| <artifactId>hibernate-enhance-maven-plugin</artifactId> | ||
| <version>5.2.17.Final</version> |
There was a problem hiding this comment.
i'm open to suggestions on how to manage this build dependency - as it's required for hibernate to run in jdk9+ at runtime (tests will pass without it). i've tried a few things here:
- placing this stanza in parent pom didn't work
- referencing version info from parent pom didn't work
- leaving the version out generates a warning
- placing this inside the docker build plugin section means non-docker builds will generate jars which won't work during run time
|
Thank you for the contribution, I will look into during weekend :) |
|
@notsureifkevin please see #130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #102
this will probably work with v11, but I don't have a machine where I can test it out.