Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of the spring-petclinic-monitoring module #89

Closed
arey opened this issue Sep 14, 2018 · 2 comments
Closed

Removal of the spring-petclinic-monitoring module #89

arey opened this issue Sep 14, 2018 · 2 comments
Assignees
@arey
Labels
enhancement

Comments

@arey
Copy link
Member

arey commented Sep 14, 2018

@mszarlinski, in order to simplify the base code, I suggest to remove the spring-petclinic-monitoring Maven module shared by all the microservices. Monitoring metrics are now sent to Zipkin trough distributed traces. What do you think about?
@arey arey added the question label Sep 14, 2018
@mszarlinski
Copy link
Collaborator

👍 it is some legacy stuff

@arey arey assigned arey and unassigned mszarlinski Sep 14, 2018
@arey arey added enhancement and removed question labels Sep 14, 2018
@arey
Copy link
Member Author

arey commented Sep 14, 2018

Ok I take this change.

arey added a commit to arey/spring-petclinic-microservices that referenced this issue Sep 23, 2018
@arey
spring-petclinic#89 Removal of the spring-petclinic-monitoring module
2d92a27
mszarlinski pushed a commit that referenced this issue Sep 23, 2018
@arey @mszarlinski
#89 Removal of the spring-petclinic-monitoring module (#96)
9c93f21
@arey arey closed this as completed Sep 24, 2018
talha-01 pushed a commit to talha-01/microservices-ci-cd-pipeline-with-petclinic-app that referenced this issue Nov 13, 2020
@arey @mszarlinski
spring-petclinic#89 Removal of the spring-petclinic-monitoring module (…
05f8545 
…spring-petclinic#96)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arey arey

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arey @mszarlinski