Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to dockerfile-maven or Google Jib #82

Closed
arey opened this issue Jul 12, 2018 · 4 comments
Closed

Migrate to dockerfile-maven or Google Jib #82

arey opened this issue Jul 12, 2018 · 4 comments

Comments

@arey
Copy link
Member

arey commented Jul 12, 2018

Spotify recommand recommend that new projects use dockerfile-maven instead of the old github.com/spotify/docker-maven-plugin.
We could also migrate to Google Jib: https://github.com/GoogleContainerTools/jib

@arey arey changed the title Migrate to dockerfile-maven Migrate to dockerfile-maven or Google JIB Feb 17, 2019
@arey arey changed the title Migrate to dockerfile-maven or Google JIB Migrate to dockerfile-maven or Google Jib Feb 17, 2019
arey added a commit to arey/spring-petclinic-microservices that referenced this issue Feb 26, 2019
@arey
Copy link
Member Author

arey commented Feb 26, 2019

I've tried to migrate to Google Jib with the jib-maven-plugin but I'm not satisfied with it: the is no version of Dockerize for the gcr.io/distroless/java image and the wait-for-it.sh script is not working. Thus I have to use the openjdk:8 Docker image.

You could check my commit: arey@1da92dd

@damc-dev
Copy link
Contributor

Hey @arey, I checked out your commit on Windows 10 and the docker containers failed to start up due to this error: /usr/bin/env: ‘bash\r’: No such file or directory.
Since git checks out files with the default line endings of the OS on Windows it defaults to CRLF. I was able to use the dos2unix command to convert to unix line endings. after that the wait-for-it.sh worked as expected.

I have an interest in getting this merged into master, is there anything I can do to help?

@arey
Copy link
Member Author

arey commented Apr 26, 2019

Hi @damc-dev I've added a .gitattributesfile to my feature/jibbranch: https://github.com/arey/spring-petclinic-microservices/blob/feature/jib/.gitattributes
It should solve your issue without having to use dos2unix tool.

It could be great to use dockerize instead of wait-for-it.sh. Microservices startup appears be more stable with it.

@arey
Copy link
Member Author

arey commented Jun 22, 2020

Spring Boot layered jars is preferred to Google Jib: #155

@arey arey closed this as completed Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants