Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds chaos monkey setup #14

Merged
merged 6 commits into from
Apr 26, 2021
Merged

Conversation

marcingrzejszczak
Copy link
Contributor

@arey
Copy link
Member

arey commented Apr 23, 2021

Sorry I missed this PR. I will check

@@ -54,6 +54,19 @@ management:
prometheus:
enabled: true

# Chaos Engineering
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The run_all.sh script starts the Spring Boot app with the profile --spring.profiles.active=chaos-monkey. Thus I propose to move this config section in a dedicated one like for mysql:

spring:
  config:
    activate:
      on-profile: chaos-monkey

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure no problem

application.yml Outdated
watcher:
component: false
controller: false
# Defaults to potential issues with repositories - can be changed via REST API
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this issue is referenced in the Chaos Monkey GitHub project?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah it's a copy paste from my pet project, I'll remove it

@marcingrzejszczak
Copy link
Contributor Author

Updated the YAML

application.yml Outdated
watcher:
component: false
controller: false
repository: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why the repository watcher is set to true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a sensible default but we can set it to false

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converted it to false

@arey arey merged commit 127272c into spring-petclinic:master Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants