Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A Spring Boot 3.0-based app that depends on PostgreSQL and Spring Data R2DBC uses the wrong coordinates for its r2dbc-postgresql dependency #882

Closed
wants to merge 2 commits into from
Closed

A Spring Boot 3.0-based app that depends on PostgreSQL and Spring Data R2DBC uses the wrong coordinates for its r2dbc-postgresql dependency #882

wants to merge 2 commits into from

Conversation

tisonkun
Copy link
Contributor

Reflect r2dbc/r2dbc-bom#44

This closes #881.

Signed-off-by: tison [email protected]

@pivotal-cla
Copy link

@tisonkun Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@tisonkun Thank you for signing the Contributor License Agreement!

@tisonkun
Copy link
Contributor Author

@wilkinsona I made a direct change on the customize method. But possibly there should be conditions based on Spring Boot versions selected. I'm trying to see whether these is some.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 30, 2022
@wilkinsona
Copy link
Contributor

Thanks for the PR, @tisonkun.

But possibly there should be conditions based on Spring Boot versions selected

There should be. The new org.postgresql group should only be used with Boot 3.0. With 2.x, io.r2dbc needs to be used as before.

@tisonkun
Copy link
Contributor Author

@wilkinsona I hope this is the pattern the starter handles different boot versions 1aead57.

@tisonkun
Copy link
Contributor Author

cc @wilkinsona @snicoll could you please give this PR a review?

@snicoll snicoll mentioned this pull request Apr 1, 2022
Closed
@snicoll snicoll added type: bug and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 1, 2022
@snicoll snicoll changed the title Update artifact coordinates for R2DBC Postgres driver A Spring Boot 3.0-based app that depends on PostgreSQL and Spring Data R2DBC uses the wrong coordinates for its r2dbc-postgresql dependency Apr 1, 2022
@snicoll snicoll self-assigned this Apr 1, 2022
snicoll pushed a commit that referenced this pull request Apr 1, 2022
@tisonkun @snicoll
Update artifact coordinates for R2DBC Postgres driver
51e3920 
Reflect r2dbc/r2dbc-bom#44

See gh-882
snicoll added a commit that referenced this pull request Apr 1, 2022
@snicoll
Polish "Update artifact coordinates for R2DBC Postgres driver"
96b858e 
See gh-882
@snicoll snicoll closed this in 806c198 Apr 1, 2022
@tisonkun tisonkun deleted the r2dbc-pg branch August 30, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
type: bug
Projects
None yet
Milestone
No milestone
5 participants
@tisonkun @pivotal-cla @wilkinsona @snicoll @spring-projects-issues