Skip to content
This repository was archived by the owner on Mar 27, 2021. It is now read-only.

Remove static import statement that keep failing sporadically #747

Merged
merged 3 commits into from
Jan 27, 2021

Conversation

ao2017
Copy link
Contributor

@ao2017 ao2017 commented Jan 22, 2021

No description provided.

@ao2017 ao2017 requested review from adsail and a team January 22, 2021 20:29
@sming
Copy link
Contributor

sming commented Jan 22, 2021

@ao2017 do we have any idea why this is failing in this manner? A SO post or something?

@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #747 (3dc7bec) into master (687ca05) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #747   +/-   ##
=========================================
  Coverage     55.01%   55.01%           
  Complexity     3153     3153           
=========================================
  Files           747      746    -1     
  Lines         20388    20386    -2     
  Branches       1337     1337           
=========================================
  Hits          11216    11216           
+ Misses         8684     8682    -2     
  Partials        488      488           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 687ca05...3dc7bec. Read the comment docs.

@ao2017
Copy link
Contributor Author

ao2017 commented Jan 22, 2021

@ao2017 do we have any idea why this is failing in this manner? A SO post or something?

SO post ??? I am not sure, this PR simply removes the static import statement

@adsail
Copy link
Contributor

adsail commented Jan 22, 2021

Which failure in particular is this intending to resolve?

@ao2017
Copy link
Contributor Author

ao2017 commented Jan 22, 2021

Which failure in particular is this intending to resolve?

Failing to find distributions(), its occurs sporadically during compilation.

@adsail
Copy link
Contributor

adsail commented Jan 22, 2021

Which failure in particular is this intending to resolve?

Failing to find distributions(), its occurs sporadically during compilation.

I'm still getting the error on my local against this branch.

@ao2017 ao2017 merged commit 5e331a5 into master Jan 27, 2021
@delete-merged-branch delete-merged-branch bot deleted the adele/static_import_fix branch January 27, 2021 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants