This repository was archived by the owner on Mar 27, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 106
Add distribution query integration test. (Part 2 of 2) #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #737 +/- ##
============================================
+ Coverage 54.82% 55.04% +0.21%
- Complexity 3105 3128 +23
============================================
Files 742 743 +1
Lines 20191 20231 +40
Branches 1313 1317 +4
============================================
+ Hits 11070 11136 +66
+ Misses 8653 8620 -33
- Partials 468 475 +7
Continue to review full report at Codecov.
|
lmuhlha
reviewed
Jan 7, 2021
heroic-component/src/main/java/com/spotify/heroic/aggregation/AggregationCombiner.java
Outdated
Show resolved
Hide resolved
lmuhlha
reviewed
Jan 7, 2021
heroic-component/src/main/java/com/spotify/heroic/aggregation/AggregationCombiner.java
Outdated
Show resolved
Hide resolved
lmuhlha
reviewed
Jan 7, 2021
heroic-dist/src/test/java/com/spotify/heroic/AbstractClusterQueryIT.java
Outdated
Show resolved
Hide resolved
lmuhlha
reviewed
Jan 7, 2021
heroic-dist/src/test/java/com/spotify/heroic/AbstractClusterQueryIT.java
Outdated
Show resolved
Hide resolved
lmuhlha
reviewed
Jan 7, 2021
heroic-dist/src/test/java/com/spotify/heroic/AbstractClusterQueryIT.java
Outdated
Show resolved
Hide resolved
lmuhlha
reviewed
Jan 7, 2021
heroic-component/src/main/java/com/spotify/heroic/aggregation/AggregationCombiner.java
Outdated
Show resolved
Hide resolved
lmuhlha
reviewed
Jan 7, 2021
heroic-dist/src/test/java/com/spotify/heroic/AbstractClusterQueryIT.java
Outdated
Show resolved
Hide resolved
lmuhlha
reviewed
Jan 7, 2021
heroic-dist/src/test/java/com/spotify/heroic/HeroicDistributionGenerator.java
Show resolved
Hide resolved
lmuhlha
reviewed
Jan 7, 2021
rpc/grpc/src/main/java/com/spotify/heroic/rpc/grpc/GrpcRpcClient.java
Outdated
Show resolved
Hide resolved
implementation lgtm, just some small fixes |
lmuhlha
approved these changes
Jan 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds integration test for distributions query.