Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Candidate Recommendation Draft metadata checks #3032

Closed
wants to merge 1 commit into from

Conversation

anssiko
Copy link
Contributor

@anssiko anssiko commented Feb 12, 2025

CRD does not require this deadline information per process: https://www.w3.org/policies/process/#publishing-crud

Without this fix CRD builds without "Deadline" metadata will fail.

Fix #3031

CRD does not require this deadline information per process:
https://www.w3.org/policies/process/#publishing-crud

Without this fix CRD builds without "Deadline" metadata will fail.

Fix speced#3031
@tidoust
Copy link
Contributor

tidoust commented Feb 12, 2025

The contents in this folder is a copy of speced/bikeshed-boilerplate (hence the readonly in the path) and only used in tests I believe. The PR rather needs to be made against the doctypes.kdl file in speced/bikeshed-boilerplate, as that's the file that contains the live data that Bikeshed uses when it runs.

@anssiko
Copy link
Contributor Author

anssiko commented Feb 12, 2025

@tidoust thanks!

Closing this PR, superseded by speced/bikeshed-boilerplate#124

@anssiko anssiko closed this Feb 12, 2025
@anssiko anssiko deleted the fix-doctype-crd-requires branch February 12, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All Bikeshed CRD builds fail without Deadline metadata set
2 participants