Only count each WPT test once for the summary view #2304
Conversation
Previously, every .wpt-name was counted for calculating the pass/total summary, even if it had previously been seen. This would cause inaccurate results for specifications where authors list the same WPT test more than once (e.g., if the test relates to multiple parts of the spec). Fixes speced#2303
|
I think this is correct; tested locally with SPC and it seems to work. Just discovered I need to rebase the tests however, doing that now. |
| // Only update the summary pass/total count if we haven't seen this | ||
| // test before, to support authors listing the same test multiple times | ||
| // in a spec. | ||
| if (!seenTests.has(nameEl.getAttribute("title"))) { |
There was a problem hiding this comment.
I know the indentation in this file is inconsistent between tabs and spaces (ugh, I dunno how that happened) but that doesn't mean that mixing 4-space and 2-space indents is allowed as well. ^_^ Mind switching it all to tab-based?
There was a problem hiding this comment.
Whoops on the 2-space vs 4-space, my bad. Will fix that. I don't see the tabs though; I think my PR introduces the only tabs in the file actually (unless my editor is lying to me?).
Changed to all space-indented, 4-space indentation for now. If you want, I can definitely turn it all into tabs, let me know :).
Previously, every .wpt-name was counted for calculating the pass/total summary,
even if it had previously been seen. This would cause inaccurate results for
specifications where authors list the same WPT test more than once (e.g., if
the test relates to multiple parts of the spec).
Fixes #2303