[multi sdfg, fortran] Make global renaming apply only when there is a collision. Then re-enable it. #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratyai
changed the title
mcopik
reviewed
Jan 10, 2025
mcopik
requested changes
Jan 10, 2025
Lex mentioned that the suffixes are too long, but didn't suggest what it should be. Happy to comply with any suggestion that is unlikely to be a substring of anything existing. |
|
@pratyai I'm fine with shortening if it's needed - just plz make it such that the connection is obvious. |
|
So, please, no IATA airport codes :-) (YYZ is Toronto's airport) |
Done. |
phschaad
pushed a commit
that referenced
this pull request
Jan 14, 2025
… collision. Then re-enable it. (#1865)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.