-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
코드 정리 및 개선 #3
Merged
Merged
코드 정리 및 개선 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
보통 golang library에서 install란은 go get ~~~ 로 표현하는 경우가 많아서 수정했습니다.
PR 누구나 merge 가능한거 같은데 merge는 멤버만 가능하게 설정 수정 필요하지 않을까요?? @wileyday |
@KimGenius 지니가 멤버로 등록되어 있어서 머지 권한이 있었나 봅니다. 지금은 아마 안될거에요 ^^ |
wileyday
approved these changes
Sep 14, 2020
hosysy
reviewed
Sep 15, 2020
오 지니 고마와요~ @KimGenius |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
내용은 커밋 메시지 참고 부탁드립니다.
와! Golang SDK도 나왔군요 🎉